GDevelopApp / GDevelop-examples

Repository of examples and templates for GDevelop - the open-source, no-code game engine
https://gdevelop.io
53 stars 20 forks source link

[New Example] Rhythm a musical game example #81

Closed UlisesFreitas closed 3 years ago

UlisesFreitas commented 3 years ago

Rhythm a musical game for GDevelop

Basic example of how to create a music game like Dance Dance Revolution or Friday Night Funkin, The camera follows the player whos singing, and the arrows appear to that player. When the song ends calculate the scores and decides who wins.

Controls:

Checklist

Game online

https://games.gdevelop-app.com/game-f4f5cb84-335b-4346-a132-e98b223dd974/index.html

Game folder

GD-Examples-Rhythm-1.0.0.zip

Midhil457 commented 3 years ago

Hi, so this isn't a full review or something and wasn't looking with review in mind , this are some suggestions and bugs I found when I did a quick look. So, I might not have the time to do a full one, so if someone can, please do a review after me. The game itself was fun, I spent some time playing it just for fun.

UlisesFreitas commented 3 years ago

Ok, I'm going to check this out and update the project

UlisesFreitas commented 3 years ago

The game is stuck after you finish the game/get the score near 30. I don't think it's the score causing the problem, I think the end card is not shown. - Fixed it's working now

Adding a permentant force when after creating the arrow instead of subtracting the Y position might be a more "conventional" way. -Changed to Force at angle, it seems to work even better

There is an unused resource Rival-micro-5 - Fixed is one of the animations is added now.

I found the camera logic a bit confusing. Won't Centering the camera to the middle at start, and center them to the player or rival when it's their turn be fine? I think there might be a reson you chose this, but I don't know - I removed completely the camera just for the example since is not the relevant thing here.

The background layer seems to be empty -Removed

Adding a comment with the controls will be useful, I at first thought the rival controls were broken not knowing the rival used wasd 😅 :) - Did you read the description of the game? Anyway I added 2 texts in game screen to show the controls.

Here the updated version: https://games.gdevelop-app.com/game-b3b1e91b-03af-42f0-9f1e-7c2baa584c11/index.html

Here the updated project: 1.0.1 WTF-Wars-Rhythm-1.0.1.zip

Midhil457 commented 3 years ago

Hi, I got some time to take another look. I wasn't able to find much issues. I did make some small changes

I should have opened a PR for this by the time I have commented this

Thank you for the contribution! :)

Bouh commented 3 years ago

Added in GDevelop, try it.