Complex Animation with Attack Combo and Dash

Ajgamerteam commented 3 years ago

Describe the example

Complex animation including attack combo, dash, sliding, air dash, with gamepad and keyboard.

Checklist

[ ] My game has a proper name in the game properties.
[ ] My game package name behind with com.example..
[ ] My game has all events unfolded.
[ ] I've added myself as the author in the game properties.
[ ] I've included a file called "README.md" with a description in proper English, explaining what this example is doing.
[ ] I confirm that this game and all of its resources can be integrated to this GitHub repository, distributed and MIT licensed.
[ ] I've cleaned unused resources.

Game folder

StateMachineCombo.zip

Bouh commented 3 years ago

I'm not convinced by the example, I'm not for adding it. It looks like a low-quality example, the Not-A-Vania example is more complete and uses FSM.

Waiting another review otherwise we'll close it in 15 days (09/30/2021).

Ajgamerteam commented 3 years ago

Well it is an example for Animation plus it is an example not a game so i don't understand your standered about low quality and high quality the examples ARE NOT GAMES so they have to show a specific topic not using free asstes from itchio and call it complete Plus i don't seem to recall Not-A-vania having combo attack However if you want me to add something suggest something

Bouh commented 3 years ago

Hi @Ajgamerteam !

As nobody seems to be very warm to give his help I take back the hand. I reopened the example and it convinced me, movements and beautiful animations are great.

So here is the list of things to improve:

Review

Enable the nearest mode in-game properties for a pixel art game.
Disable smooth on all sprites in the resources tab.
Remove all unused resources (there is a lot of unused images)
I recommend using an FSM system it makes the event sheet cleaner and the game state are just better with it.
While you press C we can move, but the Player is crouch. Just disable movement if C is pressed, or find a walking crouch animation for it.
Same for X
Add on the scene a small text explaining which inputs the Player can use.
Add limit on the world, the Hero can fall and the scene doesn't restart :|
You use a lot of the action 'Animation by the number', instead use the animation by name it makes the events cleaner and understandable.
Object platform to Platform.
All resources should be in an assets folder.
the readme is currently README.md.txt, => "README.md"
The content in the readme change to This example shows you how to implement complex animation and how to add attack combo dashing and slide animation.
On the Player object, you have empty animations, remove all the empty things in general.
If you use version 5.0.120 please add your nickname in Author in-game properties.
I can see you use the Health extension, but the Player can't be damaged, something like spikes could be added. or something else that damage the Player.

Without changes before 31 October 2021 we'll close this submission.

Ajgamerteam commented 3 years ago

Hey Bouh Thank you for the suggestion I will implement them as soon as possible

Ajgamerteam commented 3 years ago

Complex animation 2.zip

Ajgamerteam commented 3 years ago

Just updated the Exmple hope everything is ok I know FSM is better but currently I am not at that level Thank you alot for your help

Bouh commented 2 years ago

Thx for these changes; Still do to:

Review

All resources should be in an assets folder, player animations are still on the root.
Disable smooth on all sprites of the Player in the resources tab.
Object platform to Platform, objects name have to be in PascalCase.

Controls text change the content to:

Arrows: Move
Space: Jump
Lshift: Dash
Lctrl: Slide
X: Attack
C: Block

You use a lot of the actions 'Animation by the number', instead use the animation by name it makes the events cleaner and understandable, and as the objects name use the PascalCase naming convention.
Objects Fallrespawn and Playerposition are useless, delete them. We can do without. In the events replace Player.Y() > Fallrespawn.Y() by Player.Y() > SceneWindowHeight(). And in action repalce the position action by Change to scene CurrentSceneName(). Then think to remove unused resources from the deleted objects. (Right-click in resource list then clean unused images)
Player can be stuck under the Platform after a dash. You could add an extra force to move the player or the action Separate the objects.
We shouldn't be able to use C and Dash at the same time. Btw most of conflicts animations and states can be resolved with the FSM.

Ajgamerteam commented 2 years ago

Thanks alot for your effort i will try my hand at state machine

Ajgamerteam commented 2 years ago

Hey I was searching about state machine and i stumbled upon this https://www.youtube.com/watch?v=uQ3EMVqwCRo and to be honest this is better than the one i am working with so i think you should add this instead

Bouh commented 2 years ago

Hey I was searching about state machine and i stumbled upon this https://www.youtube.com/watch?v=uQ3EMVqwCRo and to be honest this is better than the one i am working with so i think you should add this instead

@UlisesFreitas Are you ok if we include your example with the FSM in GDevelop?

UlisesFreitas commented 2 years ago

Hey I was searching about state machine and i stumbled upon this https://www.youtube.com/watch?v=uQ3EMVqwCRo and to be honest this is better than the one i am working with so i think you should add this instead

@UlisesFreitas Are you ok if we include your example with the FSM in GDevelop?

Sure no problem but this was my very first project in GD and I didn't updated nor checked since forever, I think the current version is 1.0.3 available in my other profile on itch.io https://gamesigniter.itch.io/state-machine-combo or here in GitHub https://github.com/UlisesFreitas/StateMachineCombo

Bouh commented 2 years ago

Cool! I dug into your repository and found this version: StateMachineCombo.zip

It's a lower version than on your video, I didn't find a more recent one, but it is already very complete! It also works with a gamepad! Just need to clean a bit and fit the best practice guide, and here we go 🚀

First post edited.

Midhil457 commented 2 years ago

Does this submission need a review? or is this still wip?

Bouh commented 2 years ago

Does this submission need a review? or is this still wip?

Yes I think.

Midhil457 commented 2 years ago

I'll try to do a proper review this weekend :) EDIT: I wasn't able to find time 😅. I will try to do a proper one asap In the meantime,

Unfold all events
Properly comment the events
The project doesn't work on mobile, so I don't see the point in having icons for mobile platforms
The minimum FPS is set below 20, which could bring some issues?
In the splashscreen, description1, description2, etc.. could be given more meaningful names that correspond to its

:)

Midhil457 commented 2 years ago

I forgot about this 😅,

Some variavles could be converted to bools to simplify things
Typo: Couch -> Crouch Group name PlayerEvents external events
Variables PositionX and PositionY seem to be unused
obj_floor_collidion seem to be unused
There are some instances that seem to be unused

:) good to good ig then. Though someone can review after me if they find any problems

Bouh commented 2 years ago

Closed for inactivity, we could reopen the submission if someone applies the changes request in all lists above. Thank you all.

GDevelopApp / GDevelop-examples