GDevelopApp / GDevelop-extensions

Repository of behaviors, actions, conditions and expressions to be used in GDevelop for creating games
https://gdevelop.io
MIT License
131 stars 53 forks source link

Update: Fix a context issue on FireBullet #124

Closed D8H closed 1 year ago

D8H commented 3 years ago

Describe the extension

This is a breaking change.

Checklist

Extension file

https://www.dropbox.com/s/536bbz9ktacz263/FireBullet.zip?dl=1

It's used by this example: https://github.com/4ian/GDevelop/issues/2566

arthuro555 commented 3 years ago

🤔 I wonder if we shouldn't add an action to "bubble up" the picked objects instead of using JS code, as this sounds like something that could be often useful.

4ian commented 3 years ago

Yes that's a good question. I also see that currently the JS code is clearing the list of picked objects. I think this is because it needs to work like the "Create object" action, in the sense that it's not "picking" objects when called. For this we could add a new parameter type "Object without picking" to the extensions in the editor. It actually already exists for JS/C++ extensions (see the "Create Object" action) :)

arthuro555 commented 3 years ago

I am guessing from the conversation that this won't be added until we have a built in way to "bubble up" selected objects. Adding the tag "change required in GDevelop".

tristanbob commented 1 year ago

This was implemented here, so I'm closing this issue.

https://github.com/GDevelopApp/GDevelop-extensions/pull/877