[Update] Flash and transition painter

VegeTato commented 6 months ago

Description

Added the extension author name.
Added an option for the extension action (Yes/No) to remove the paint after the transition has finished. (by default is set to Yes)

How to use the extension

No response

Checklist

[X] I've followed all of the best practices.
[X] I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
[X] I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Reviewed

Example file

Example.zip

Extension file

FlashTransitionPainter.zip

github-actions[bot] commented 6 months ago

👋 Thanks for your submission! We are sorry, but it seems we already have a reviewed extension with that name. Extensions cannot be in both the community and reviewed extensions list at once. If you are trying to update that extension, please ask a member of the extension team for help. If the name clash is a coincidence, please update your original submission post with a new zip file containing your extension with a file name that is not already taken 🙏

github-actions[bot] commented 6 months ago

👋 Thanks for your submission! We are sorry, but it seems we already have a reviewed extension with that name. Extensions cannot be in both the community and reviewed extensions list at once. If you are trying to update that extension, please ask a member of the extension team for help. If the name clash is a coincidence, please update your original submission post with a new zip file containing your extension with a file name that is not already taken 🙏

github-actions[bot] commented 6 months ago

👋 Thanks for your submission! We are sorry, but it seems we already have a reviewed extension with that name. Extensions cannot be in both the community and reviewed extensions list at once. If you are trying to update that extension, please ask a member of the extension team for help. If the name clash is a coincidence, please update your original submission post with a new zip file containing your extension with a file name that is not already taken 🙏

github-actions[bot] commented 6 months ago

👋 Thanks for your submission! We are sorry, but it seems we already have a reviewed extension with that name. Extensions cannot be in both the community and reviewed extensions list at once. If you are trying to update that extension, please ask a member of the extension team for help. If the name clash is a coincidence, please update your original submission post with a new zip file containing your extension with a file name that is not already taken 🙏

tristanbob commented 6 months ago

I looked into this update. I wasted some time thinking this was like tweens and deleting the object, but I think you want the paint to stay in the final position after it is completed. We need to think of the best wording for this option.

VegeTato commented 6 months ago

I looked into this update. I wasted some time thinking this was like tweens and deleting the object, but I think you want the paint to stay in the final position after it is completed. We need to think of the best wording for this option.

Not sure what you mean at the tweens part, yea i just want the paint to stay in the final position when its completed 👍

The current one is not good ? (Remove the paint when the transition has finished) I mean it says what it supposes to do

D8H commented 6 months ago

This extension is overly complicated. I guess the 3 of us have wasted too much time on it so I rewrote it with half the events and fixed a few things:

https://github.com/GDevelopApp/GDevelop-extensions/pull/1258

I think that the black screen should always be kept so I didn't added a parameter like VegeTato suggested but forced it. Users can always clear the shape painter if they need to.

Please take a look to the PR and tell me what you think about the changes and the todo list (for a future PR that I probably won't do).

VegeTato commented 6 months ago

This extension is overly complicated. I guess the 3 of us have wasted too much time on it so I rewrote it with half the events and fixed a few things:
* [[Transition] Fix the animation for zoomed layers #1258](https://github.com/GDevelopApp/GDevelop-extensions/pull/1258)
I think that the black screen should always be kept so I didn't added a parameter like VegeTato suggested but forced it. Users can always clear the shape painter if they need to.

Please take a look to the PR and tell me what you think about the changes and the todo list (for a future PR that I probably won't do).

Perfect ! i responded in the PR.

GDevelopApp / GDevelop-extensions