GDevelopApp / GDevelop-extensions

Repository of behaviors, actions, conditions and expressions to be used in GDevelop for creating games
https://gdevelop.io
MIT License
131 stars 53 forks source link

Weapon Attack System #636

Closed Delvinn0 closed 2 years ago

Delvinn0 commented 2 years ago

Description

This extension is to make Weapons Attack system for rpg, this is only sword for now, i'll update this extension in the future and i want that this extension become an huge extension like the Health extension

How to use the extension

Add an event without condition and put the "Execute An Attack (Sword)" action

Checklist

What tier of review do you aim for your extension?

Reviewed

Example file

Weapon Melee Extension.zip

Extension file

WeaponAttack.zip

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [No 'Get' in expressions]: Expression 'GetKnockValue' is using prohibited 'Get' prefix

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [No 'Get' in expressions]: Expression 'GetKnockValue' is using prohibited 'Get' prefix

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [No 'Get' in expressions]: Expression 'GetKnockValue' is using prohibited 'Get' prefix

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'OnExecute' misses a dot at the end of the sentence

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'shortDescription' of the extension description misses a dot at the end of the sentence

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

github-actions[bot] commented 2 years ago

Hi @DelltDev! 👋 This submission has passed all required tests, and has been moved to a PR as part of our submission pipeline. You can see the progress of your submission on this page. Community submissions are not reviewed by default, so your extension should be added once we've checked that your submission doesn't contain malicious code without further intervention on your part. If you wish for your extension to be reviewed (and thereby moved to the list of reviewed extensions), please follow the instructions written on the README. Thanks again for your contribution to GDevelop!