GDevelopApp / GDevelop-extensions

Repository of behaviors, actions, conditions and expressions to be used in GDevelop for creating games
https://gdevelop.io
MIT License
131 stars 53 forks source link

HasLanded for comunity list #645

Closed shadow00dev closed 2 years ago

shadow00dev commented 2 years ago

Description

this extension checks if an object(which has PlatformerObject behaviour) has landed on the floor

here is a playable example https://liluo.io/instant-builds/f4559a13-797a-4c3d-8339-b8aafdaf71ae

Note: I do have another pr request for this https://github.com/GDevelopApp/GDevelop-extensions/pull/359 but got told(by someone on discord) to make a new one for it to be in the community list

How to use the extension

  1. open or create a project(well basically a platformer game will do(as long as the object you want to check if landed has the platform object behaviour
  2. create an event
  3. add the condition "HasLanded"
  4. setup the condition to how you like it
  5. test

Checklist

What tier of review do you aim for your extension?

Community (Unreviewed)

Example file

HasLandedExtensionAndExample.zip

Extension file

HasLanded.zip

Note

both files have been updating

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Filled out names and descriptions]: Required field 'shortDescription' of the extension description is not filled out

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Filled out names and descriptions]: Required field 'shortDescription' of the extension description is not filled out

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

shadow00dev commented 2 years ago

huh this worked before

shadow00dev commented 2 years ago

i also forgot a title lol

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Filled out names and descriptions]: Required field 'shortDescription' of the extension description is not filled out

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

shadow00dev commented 2 years ago

HasLandedExtensionAndExample.zip

okay uh i think this should be good

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'Landed' misses a dot at the end of the sentence

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'Landed' misses a dot at the end of the sentence

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

shadow00dev commented 2 years ago

ooh forgot a dot i swear i didnt lol

shadow00dev commented 2 years ago

there's a dot on both descriptions

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Dots in sentences]: Field 'description' of the function 'Landed' misses a dot at the end of the sentence

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

shadow00dev commented 2 years ago

ooh i realised my mistake

shadow00dev commented 2 years ago

okay that should be good now uh sorry for taking long im rushing which is a stupid move from me lol

github-actions[bot] commented 2 years ago

👋 Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply 😔. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟶ ❌ [Extension name consistency]: Extension filename should be exactly the name of the extension (with .json extension). Please rename 'HasLandedExtension.json' to 'HasLanded.json'

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines 🙏

shadow00dev commented 2 years ago

bruh okay

shadow00dev commented 2 years ago

i guess i should of re-read it and not rely on my memory lol

github-actions[bot] commented 2 years ago

Hi @shadow00dev! 👋 This submission has passed all required tests, and has been moved to a PR as part of our submission pipeline. You can see the progress of your submission on this page. Community submissions are not reviewed by default, so your extension should be added once we've checked that your submission doesn't contain malicious code without further intervention on your part. If you wish for your extension to be reviewed (and thereby moved to the list of reviewed extensions), please follow the instructions written on the README. Thanks again for your contribution to GDevelop!