4ian
commented
3 years ago Great idea :) This is overall looking good, I have multiple nitpickings so that the extension reach an almost perfect state:
A few feedbacks:
- Use USA English for names and PascalCase for the extension name:
ColorConversion - In tags: hexidecimal =>
hexadecimal. Addcolor. Don't use plural:conversion - Period at the end of sentences:
Convert RGB color values into various other colour formats and vice versa. - Let's use "invert-colors" for the icon :)
- For
name to RGB, either use an explicit object containing the values (const colorNameToRgb = { red: "255;0;0", ... }), or remove the function. We don't use as much as possible CSS/getComputedStyle/getPropertyValue. It's implementation specific and it forces to create a div, which will create memory pressure on the garbage collector and is super inefficient. Basically never ever use DOM manipulation for games. - Always use triple equal everywhere in JavaScript:
minRGB == maxRGB=>minRGB === maxRGB. Never use==. - Nitpicking:
let H = 0=>let h = 0(use camelCase for variables, not PascalCase). - For RgbToHex, please use
gdjs.rgbToHex;) See https://docs.gdevelop-app.com/GDJS%20Runtime%20Documentation/gdjs.html#.rgbToHex - For HexToRgb:
- you have a useless variable:
const n = eventsFunctionContext.getArgument("n"); let hex = n;. Just name your parameter "hex".
- you have a useless variable:
Finally, for all functions can you verify what is going on if you enter an invalid value as a parameter? Thanks! :)
Add00
Describe the extension
A simple extension that converts rgb values into other colour formats.
Checklist
Extension file
colourConversions.zip