GDevelopApp / GDevelop-extensions

Repository of behaviors, actions, conditions and expressions to be used in GDevelop for creating games
https://gdevelop.io
MIT License
119 stars 49 forks source link

New extension: One Signal Notification #988

Closed TheGemDev closed 10 months ago

TheGemDev commented 11 months ago

Description

Send push Android/IOS notifications via one signal

How to use the extension

Make use of the initialize one signal action

image

go to https://onesignal.com to create an account.

Follow these steps to generate a Google server API key https://documentation.onesignal.com/docs/generate-a-google-server-api-key

Checklist

What tier of review do you aim for your extension?

Community (Unreviewed)

Example file

msg.zip

Extension file

OneSignal.zip

github-actions[bot] commented 11 months ago

πŸ‘‹ Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply πŸ˜”. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'Initialize' misses a dot at the end of the sentence!
  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'UserEmail' misses a dot at the end of the sentence!
  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'UserSMS' misses a dot at the end of the sentence!
  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'Login' misses a dot at the end of the sentence!

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines πŸ™

github-actions[bot] commented 11 months ago

πŸ‘‹ Thanks for your submission! Unfortunately, all submitted extensions have to meet some minimal quality standard - the extension best practices - and our system has found that your extension does not fully comply πŸ˜”. You can find all of those rules on the GDevelop wiki.

The following issues have been found by the system concerning the respect of those best practices by your extension:

  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'Initialize' misses a dot at the end of the sentence!
  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'UserEmail' misses a dot at the end of the sentence!
  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'UserSMS' misses a dot at the end of the sentence!
  ⟢ ❌ [Dots in sentences]: Field 'description' of the function 'Login' misses a dot at the end of the sentence!

Please update your original submission post with a new zip file containing your extensions updated to follow those guidelines πŸ™

TheGemDev commented 11 months ago

OneSignal.zip

github-actions[bot] commented 10 months ago

Hi @arthuro555! πŸ‘‹ This submission has passed all required tests, and has been moved to a PR as part of our submission pipeline. You can see the progress of your submission on this page. Community submissions are not reviewed by default, so your extension should be added once we've checked that your submission doesn't contain malicious code without further intervention on your part. If you wish for your extension to be reviewed (and thereby moved to the list of reviewed extensions), please follow the instructions written on the README. Thanks again for your contribution to GDevelop!

ElRamo commented 5 months ago

Hello, Thank you for your amazing contribution. I am trying to integrate the extension but somehow I am not able to register new subscribers. I followed the guide bellow OneSignal Documentation Android: Firebase Credentials

Directions on how to generate a Firebase Cloud Messaging API Credentials for sending Android App Notifications

1/ Activate Firebase Cloud Messaging API (V1) 2/ Generate a Private Key JSON file (Node.js) 3/ Activate the platform Google Android (FCM) in OneSignal (In the part β€œSelect SDK” I tried both Native android and Cordova) 4/ Download and import the extention in Gdevelop (Onesignal GDevelop Extension Β· GitHub) 5/ Integrate it as follow : Beginning of the first scene >

I tried the application using mobile manual build and mobile One-click packaging. I tested the .apk in a real phone and in android studio virtual devices (with playstore installed). I checked, the notification is allowed. But still, when I launch the application no new subscriber is registered in OneSignal. Thank you in advance for your precious time.