GEGlobalResearch / DARPA-ASKE-TA1

ANSWER Project to demonstrate knowledge-driven extraction of scientific models from code and texts
Other
8 stars 5 forks source link

SADL preferences not being loaded by Dialog model processor #24

Closed crapo closed 5 years ago

crapo commented 5 years ago

The JenaBasedDialogModelProcessor (JBDMP) extends the JenaBasedSadlModelProcessor (JBSMP) and much of the model processing is passed off to the superclass processor. It is, therefore, necessary that the superclass processor use the SADL preferences. This is not happening. For example, the SADL preference "use indefinite and definite articles..." is checked, but when processing passed from the JBDMP, it is false, resulting in erroneous processing. I added what I thought was a missing call in JBDMP.initializePreferences to JBSMP.initializePreferences (super.initializePreferences call), but that did not appear to resolve the issue. I added "@Inject IPreferenceValuesProvider preferenceProvider;" to the JBDMP because the RCE JBSMP extension class, which I think works, has such an insertion, even though it seems to be unused, but of course that made no difference. @kittaakos , can you suggest why the SADL preferences aren't getting set?

kittaakos commented 5 years ago

This is not happening

Yes, it won't work. This is a little bit tricky, but I am working on a quick solution...