Fixed a potential deadlock case when getting the preferences,

GEGlobalResearch / DARPA-ASKE-TA1

ANSWER Project to demonstrate knowledge-driven extraction of scientific models from code and texts

Other

8 stars 5 forks source link

Fixed a potential deadlock case when getting the preferences, #52

Closed kittaakos closed 4 years ago

kittaakos commented 4 years ago

and when inserting into the document. Switched from sync to async.

Signed-off-by: Akos Kitta kittaakos@typefox.io

crapo commented 4 years ago

Do we want to merge this? I don't really know what to look for in review....

kittaakos commented 4 years ago

Do we want to merge this?

+1 for merging it, but it would make sense to test it on your side.

crapo commented 4 years ago

@kittaakos , I didn't see any issues here initially, but now I'm seeing that the insertions, on loading a dialog file with multiple questions do not happen in the right place. There seems to be some evidence that the issue is that it doesn't take into account the length of previous insertions. Perhaps we can discuss next week.