GEM-benchmark / GEM-metrics

Automatic metrics for GEM tasks
https://gem-benchmark.com
MIT License
60 stars 20 forks source link

Change cached_property and union operator for backwards compatibility #69

Closed j-chim closed 2 years ago

j-chim commented 2 years ago

Currently the library requires Python >= 3.9 due to using functools.cached_property and dict union. This creates a problem for users who can't easily change versions/environments (eg Colab/Kaggle).

(also see: https://github.com/GEM-benchmark/GEM-metrics/issues/61)

This PR makes the library backwards compatible and has been tested on 3.7.

tuetschek commented 2 years ago

Looks good to me. @sebastianGehrmann OK to merge?

sebastianGehrmann commented 2 years ago

Yep looks good!