search

GEM-benchmark / GEM-metrics

Automatic metrics for GEM tasks
https://gem-benchmark.com
MIT License
60 stars 20 forks source link

MoverScore #91

Closed jordiclive closed 2 years ago

jordiclive commented 2 years ago

Adding MoverScore metric. A referenced heavy metric.

tuetschek commented 2 years ago

@jordiclive: thanks for adding this! I've just tested it locally and it works fine, there's just one slight problem with installation – pyemd doesn't install with the moverscore package, so I had to install it by hand. The moverscore repo has the dependency in requirements.txt, but not in setup.py.

I guess the correct solution would be asking the authors to add the dependency & wait, but maybe we just can add this explicitly into requirements-heavy.txt? What do you think?

jordiclive commented 2 years ago

@tuetschek No problem! Yes, I noticed that. I thought I added it to requirements-heavy.txt, so that was what I was going to suggest.

tuetschek commented 2 years ago

Oops, I can actually see it there now – maybe I messed up something in my checkout. Thanks @jordiclive !