search

GEMDAT-repos / GEMDAT

Python toolkit for molecular dynamics analysis
https://gemdat.readthedocs.io
Apache License 2.0
21 stars 3 forks source link

Tests are failing #312

Closed stefsmeets closed 1 month ago

stefsmeets commented 1 month ago

Seems to be related to image sizes, I just checked and it runs fine on my pc, might be something in the CI?

 =========================== short test summary info ============================
FAILED tests/integration/plot_test.py::test_jumps_3d[png] - matplotlib.testing.exceptions.ImageComparisonFailure: Image sizes do not match expected size: (500, 525, 3) actual size (500, 524, 3)
FAILED tests/integration/plot_test.py::test_jumps_3d_animation[png] - matplotlib.testing.exceptions.ImageComparisonFailure: images not close (RMS 4.665):
    result_images/plot_test/jumps_3d_animation.png
    result_images/plot_test/jumps_3d_animation-expected.png
    result_images/plot_test/jumps_3d_animation-failed-diff.png
stefsmeets commented 1 month ago

I can reproduce the fail in clean environments of python 3.10, 3.11 and 3.12

Could be caused by some dependency version difference. We might need to update the data files with a fresh install.

stefsmeets commented 1 month ago

Matplotlib fail is caused by an update from 3.8 (local) to 3.9 (ci). They are minor changes: the 3d plots now have double the ticks on the y axis.

Plotly fail is caused by an update from 5.18 (local) to 5.22 (ci). The location of the axis label shifted slightly.