GEMDAT-repos / GEMDAT

Python toolkit for molecular dynamics analysis
https://gemdat.readthedocs.io
Apache License 2.0
21 stars 3 forks source link

Add plotly plot for shape #324

Closed SCiarella closed 4 months ago

SCiarella commented 4 months ago

This PR closes #315 implementing the shape plot using plotly, like this: aaa

Testing is also implemented.

Notice that I have also set the requirement for pytest>=8.1 because of some rounding errors that make the plotly test fail.


Before merging this PR, it is still needed to check if

This can be fulfilled following this link and testing the notebook with the correct input data.

SCiarella commented 4 months ago

I have implemented the suggested changes, in particular:

I have not improved however the loop because I can not identify an obvious solution either.

Before finalizing this PR, I would like to test using the same data used here. @stefsmeets Can you share them?

stefsmeets commented 4 months ago

Nice work! 🚀

stefsmeets commented 4 months ago

Now we have all the plots for both matplotlib and plotly 😁