search

GEMINI-Medicine / Rgemini

A custom R package that provides a variety of functions to perform data analyses with GEMINI data
https://gemini-medicine.github.io/Rgemini/
Other
3 stars 0 forks source link

103 disability function bug fix #118

Closed wankiewiczm-smh closed 2 months ago

wankiewiczm-smh commented 2 months ago

Updated disability function to return correct cohort when component_wise = FALSE.

Also updated NEWS.md

loffleraSMH commented 2 months ago

@wankiewiczm-smh: Just one small clarification for the unit test (in case you decide to add it). To make this more meaningful, the test cohort input should be changed to remove one of the genc_ids, e.g., you can change line 8 to something like this:

cohort <- data.table(genc_id = c(unique(ipdiagnosis$genc_id)[1:length(unique(ipdiagnosis$genc_id))-1], 888, 999))
loffleraSMH commented 2 months ago

Thanks for adding the unit test @wankiewiczm-smh! I reviewed it and everything looks good. You can go ahead and merge this now (using "Squash and merge").