There is currently a function called compute_duration_er_stay in GEMINIpkg that should be reviewed and moved into Rgemini.
The function already looks well written and documented, but it should be carefully reviewed according to the guidelines in the Code Review Checklist.
For example:
Function should be renamed to something like er_stay_duration in line with Rgemini naming conventions (i.e., remove compute)
idvar1/idvar2 should be removed in line with other Rgemini functions (genc_id can be hard-coded; triagevar2/leftvar2 could potentially be kept as optional input arguments - reviewer should decide)
Check that documentation is complete and up-to-date (e.g., add link to GEMINI data dictionary etc.)
Once the function has been reviewed and moved to Rgemini, it should be deprecated from GEMINIpkg and should be moved into the Deprecated_Rgemini.R file.
New Feature Request
There is currently a function called
compute_duration_er_stayinGEMINIpkgthat should be reviewed and moved intoRgemini.The function already looks well written and documented, but it should be carefully reviewed according to the guidelines in the Code Review Checklist. For example:
er_stay_durationin line withRgemininaming conventions (i.e., removecompute)idvar1/idvar2should be removed in line with otherRgeminifunctions (genc_idcan be hard-coded;triagevar2/leftvar2could potentially be kept as optional input arguments - reviewer should decide)Once the function has been reviewed and moved to
Rgemini, it should be deprecated fromGEMINIpkgand should be moved into theDeprecated_Rgemini.Rfile.Mention branch on GEMINIpkg to reviewer.
Any suggested reviewers?
*