Closed loffleraSMH closed 9 months ago
Depending on which is merged first (this or
mlaps
), I would like to push a commit to this branch or the mlaps branch that replaces the olddummy_admdad
function used in themlaps
unit tests with this newdummy_ipadmdad
function.
On second thought, after trying to implement this, I think this might be better handled in a different issue. For the mlaps
tests we need fine control over exactly what the admission_date_time
is.
Depending on which is merged first (this or
mlaps
), I would like to push a commit to this branch or the mlaps branch that replaces the olddummy_admdad
function used in themlaps
unit tests with this newdummy_ipadmdad
function.On second thought, after trying to implement this, I think this might be better handled in a different issue. For the
mlaps
tests we need fine control over exactly what theadmission_date_time
is.
Ah yes, sorry I missed that aspect. Agree this should be moved to a separate issue then. Will still go ahead and address your comments above so we can merge this into develop (might come in handy for other functions).
Thanks for reviewing @vaakesan-SMH! I've addressed your comments and fixed the bug.
@loffleraSMH, the dummy_ipadmdad
function has been merged to develop
. However, I received the following CI/CD check error about the function after merging develop into the frailty branch. Looks like there is an inconsistency in argument name and use for the function. Could you look into this?
Thanks @gemini-wenb, good catch! Sorry, we missed that. I just pushed a fix to develop
, can you check if it works now?
Thanks @gemini-wenb, good catch! Sorry, we missed that. I just pushed a fix to
develop
, can you check if it works now?
It works now! Thanks for fixing it!
Closes issue #52
Adds new function to simulate dummy "ipadmdad" table (currently only simulates a subset of variables that are relevant for testing).
Example usage:
Note: This function was originally developed to test plotting functions that are currently still in development (see issue #14). There is no need to review the fine-grained details of the simulations right now (e.g., degree of hospital-level variance). Instead, this is mostly just to have a starting point for a function simulating ipadmdad data, which can be further enhanced in the future depending on the scenarios it is used in (e.g., allow more user-control to create certain test scenarios).
Once this function has been reviewed and approved, the
dummy_admdad()
function created for the purpose ofmlaps
testing should be removed and replaced with this more general function.