search

GEMINI-Medicine / Rgemini

A custom R package that provides a variety of functions to perform data analyses with GEMINI data
https://gemini-medicine.github.io/Rgemini/
Other
3 stars 0 forks source link

36 census zeros #57

Closed loffleraSMH closed 8 months ago

loffleraSMH commented 9 months ago

Closes issue #36

I added a new input argument include_zero allowing users to include/exclude days where census = 0. Default is include_zero = TRUE to replicate the outcome of the previous version of this function where counts of 0 were included. I've added some context/example scenarios to the roxygen and the vignette. I've also added some unit tests and made sure the output of this function (with default inputs) is identical to the previous version.

I also cleaned up some warning messages regarding exclusion of SCU encounters.

unityarshad commented 8 months ago

@loffleraSMH Please resolve the conflict (domain name) and should be good to go :)

loffleraSMH commented 8 months ago

Thanks @unityarshad for the review! Fixed the merge conflict and will go ahead and merge.