Closed gemini-wenb closed 8 months ago
This looks good to me. Built the documentation and checked the rendered help pages. Do we want to add our new citation/reference standards/requirements to
CONTRIBUTING.md
?Also just confirming that we don't want to create hyperlinks to the DOI addresses in the roxygen?:
Thanks for reviewing @vaakesan-SMH! Great idea to add the reference standard to the CONTRIBUTING.md
- should we do this for this sprint or add this as a backlog issue? For not making DOI addresses into links, I tend to see the References
section as the References
list in journal publications, thus by not making DOI into links (which hides the actual DOI address) but showing them as they are makes the items similar to how actual citations would look like; this also distinguishes journal articles from online website resources - open to other ideas :)
Happy to leave the DOI addresses as-is.
Lets update the CONTRIBUTING.md
in this merge request.
Happy to leave the DOI addresses as-is.
Lets update the
CONTRIBUTING.md
in this merge request.
Sounds good. Let me update that!
Looks good to me, thanks Bijun. Please go ahead and merge.
I've added a description of citation standard to CONTRIBUTING
. I also added checking citation style to the Code review checklist
. @vaakesan-SMH could you give it a quick check and if everything looks ok I'll merge the request.
I've added a description of citation standard to
CONTRIBUTING
. I also added checking citation style to theCode review checklist
. @vaakesan-SMH could you give it a quick check and if everything looks ok I'll merge the request.
looks great!
Closes #47
This PR standardizes citation styles for
references
section in function documentation.Notes:
Not all functions require a
references
section. To introduce some general structure to function documentation. Thereferences
section should typically be used when users are encouraged to include function-specific citations to their publications.Rgemini
would be sufficient).frailty_score()
is developed based on a development paper, thereby, a citation is needed and it is included to thereferences
section. Whereas,icd_to_ccsr()
contains links to CIHI documentation of diagnosis definitions in function description, and these links don't need to be repeated in thereference
section as they are not required citations.Standard formatting style (aim to be simple):
Journal articles
: 1st_author_last_name initial, et al. Journal Abbrev, Year. https://doi.org/xxxx (written out, no hyperlink, should use doi url instead of others like pubmed url).Online doc
: [description] (hyperlink)