GEMINI-Medicine / Rgemini

A custom R package that provides a variety of functions to perform data analyses with GEMINI data
https://gemini-medicine.github.io/Rgemini/
Other
3 stars 0 forks source link

#47 standardize citations #63

Closed gemini-wenb closed 8 months ago

gemini-wenb commented 8 months ago

Closes #47

This PR standardizes citation styles for references section in function documentation.

Notes:

Not all functions require a references section. To introduce some general structure to function documentation. The references section should typically be used when users are encouraged to include function-specific citations to their publications.

Standard formatting style (aim to be simple):

gemini-wenb commented 8 months ago

This looks good to me. Built the documentation and checked the rendered help pages. Do we want to add our new citation/reference standards/requirements to CONTRIBUTING.md?

Also just confirming that we don't want to create hyperlinks to the DOI addresses in the roxygen?:

image

Thanks for reviewing @vaakesan-SMH! Great idea to add the reference standard to the CONTRIBUTING.md - should we do this for this sprint or add this as a backlog issue? For not making DOI addresses into links, I tend to see the References section as the References list in journal publications, thus by not making DOI into links (which hides the actual DOI address) but showing them as they are makes the items similar to how actual citations would look like; this also distinguishes journal articles from online website resources - open to other ideas :)

vaakesan-SMH commented 8 months ago

Happy to leave the DOI addresses as-is.

Lets update the CONTRIBUTING.md in this merge request.

gemini-wenb commented 8 months ago

Happy to leave the DOI addresses as-is.

Lets update the CONTRIBUTING.md in this merge request.

Sounds good. Let me update that!

vaakesan-SMH commented 8 months ago

Looks good to me, thanks Bijun. Please go ahead and merge.

gemini-wenb commented 8 months ago

I've added a description of citation standard to CONTRIBUTING. I also added checking citation style to the Code review checklist. @vaakesan-SMH could you give it a quick check and if everything looks ok I'll merge the request. image

vaakesan-SMH commented 8 months ago

I've added a description of citation standard to CONTRIBUTING. I also added checking citation style to the Code review checklist. @vaakesan-SMH could you give it a quick check and if everything looks ok I'll merge the request. image

looks great!