search

GEMScienceTools / gmpe-smtk

Python and OpenQuake-based Toolkit for Analysis of Strong Motions and Interpretation of GMPEs
GNU Affero General Public License v3.0
43 stars 33 forks source link

Add a own version (with git support) and fix some pep8 #108

Closed daniviga closed 5 years ago

daniviga commented 5 years ago

As discussed, implement a version number that is not the one from the Engine.

The old approach had some ugly side effects: i.e. in an installation from GIT the __version__ contained the git hash, but not the one from smtk, instead it contained the one from the Engine This caused some issue while preparing the OpenQuake VM, that's why I'm pushing for these changes.

micheles commented 5 years ago

I wonder about the line 'openquake.engine ==3.6' in the setup.py. Will this cause issues? I want to be able to use the same branch on the engine repo and the smtk repo, even if the engine is more updated than the smtk. Why not 'openquake.engine >=3.6' ?