search

GEMScienceTools / oq-mbtk

OpenQuake Model Building Toolkit, a suite of tools for building components and analysing models for PSHA.
https://gemsciencetools.github.io/oq-mbtk/index.html
GNU Affero General Public License v3.0
14 stars 8 forks source link

fixing handling of merge log files #338

Closed kirstybayliss closed 1 year ago

kirstybayliss commented 1 year ago

log files for merge were not being passed correctly to the merge function and so merge log files were created in a default location, except on windows where this didn't work. Now log file can be specified under 'general' or with a specific catalogue in the .toml and should be passed correctly, and where no default is supplied the file will be stored in the location of the .toml file (which is now set up to work with windows file locations).

vot4anto commented 1 year ago

Unfortunately the test is still broken, maybe it is possible to use the module-tempfile of python3: https://docs.python.org/3/library/tempfile.html#module-tempfile

kirstybayliss commented 1 year ago

Ah, I was still trying to make a .tmp file! Thanks for the suggestion, I have modified to use tempfile so hopefully it passes now...