GEMakers / gea-plugin-dishwasher

Dishwasher plugin for the GEA SDK
GNU General Public License v2.0
13 stars 6 forks source link

Remove cycleNumber field from CycleData0 through CycleData4 #21

Closed 0xbarrett closed 8 years ago

0xbarrett commented 8 years ago

As @hixie identified in #9, the cycleNumber field in dishwasher.cycleData0 through dishwasher.cycleData4 is giving unexpected results. It turns out that this field does not exist in the ERD data coming from the dishwasher.

Hixie commented 8 years ago

I'm skeptical about this patch. The data I get for all the fields after cycleNumber is self-consistent. For example, the cycle duration goes up by one minute every minute. The temperatures are exactly in the expected range, and go up at expected times in the cycle.

Is it possible that the cycleTime is just 16 bits? That would explain why very occasionally I see a cycleNumber 1 with a duration 0, that would be a 4h 16m program. That would be consistent with those always happening when I'm doing a Heavy, Steam, Heated Dry cycle.

0xbarrett commented 8 years ago

Good catch. I just checked the code and it turns out that the cycleDuration is 16-bits instead of 8. The cycle time is still 32-bits. But you're right, that explains why the cycleNumber would be 1 for cycles that exceed 255 minutes.

Hixie commented 8 years ago

Er, right, I meant cycleDuration.

Hixie commented 8 years ago

LGTM, for whatever that's worth. :-)

0xbarrett commented 8 years ago

/cc: @bakerface