Open Chamindana opened 7 years ago
Mock-up design of the proposed UI - Filter search
201610241706-PN
201610251536 PN pabodhaW pushed 2 commits to campus:c11-criteria-based-filter-search-pn
201610252314 PN pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-pn
201610261715 PN pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-pn
201610271718 PN pabodhaW pushed 4 commits to campus:c11-criteria-based-filter-search-pn
201610281042 PN pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-pn
201610281117 PN pabodhaW pushed 1 commit to campus:c11-criteria-based-filter-search-pn
201610301944 PN
Commits on Oct 29, 2016 c11-criteria-based-filter-search: renamed class ProgramTown -> ProgrammeTown. - d0662d2 c11-criteria-based-filter-search implemented getAll() method for retrieve existing details - abe942e c11-criteria-based-filter-search modified sql query inside getAll() method. - 82517c2 PN c11-criteria-based-filter-search implemented findById() method. - fd7f1d0 c11-criteria-based-filter-search INIT the class and implemented execute() method. - 0909b4f c11-criteria-based-filter-search: added LIST_LEVEL_DATA,LIST_TOWN_DATA,LIST_MAJOR_DATA,LIST_DISTRICT_DATA attributes accordingly. - f200946
Commits on Oct 30, 2016 JavaScript functions to display criteria details included here. - 070d0bd Modified the servlet and command class to pass Gson data to the jsp page. - 7e77a1c Modified the UI to display data coming from the Servlet. - c5118c1 INIT the classes for display course details. - 56f6e41
I got stuck in display details which comes from servlet in jsp page.
Data is successfully passing to the JSP page from servlet and goes back to the JSP from the servlet successfully. Only thing not working here is, data not get set into the UI element.
I tried some references below as a help but I couldn't get it done.
Committing the code I have done so far and paused till I find a right thing to do also I'm planing to discuss with the team since all of us will face the same kind of problem when it comes to display the data on UI which comes from the servlet. @tharinduw FYI.
201610311014 PN
pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-pn
201610311520 PN
pabodhaW pushed 2 commits to campus:c11-criteria-based-filter-search-pn
pabodhaW pushed 1 commit to campus:c11-criteria-based-filter-search-pn
201611011652 PN
pabodhaW pushed 2 commits to campus:c11-criteria-based-filter-search-pn
pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-pn
pabodhaW pushed 6 commits to campus:c11-criteria-based-filter-search-pn
201611021233 PN pabodhaW pushed 5 commits to campus:c11-criteria-based-filter-search-pn
201611021635 PN pabodhaW pushed 5 commits to campus:c11-criteria-based-filter-search-pn
201611021635 PN pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-pn
201611022322 PN pabodhaW pushed 8 commits to campus:c11-criteria-based-filter-search-pn
201611030952 PN pabodhaW pushed 2 commits to campus:c11-criteria-based-filter-search-pn
201611031617 PN pabodhaW pushed 5 commits to campus:c11-criteria-based-filter-search-pn
201611040931 PN pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-pn
201611040932 PN
Comments for QA
@tharinduw This if FYI. Moving this issue to @HimashaFernando.
201611081130 PN Due to the design change that's intended to support both JSTL and JSON data , through the same CampusController.java (servlet) and the decision to follow the multi-page Application approach instead of SPA (Single Page Application), the rest of the code progression will be conducted in c11-criteria-based-filter-search-MP-pn branch.
201608111300 PN pabodhaW pushed 1 commit to campus:c11-criteria-based-filter-search-MP-pn
201611081437 PN pabodhaW pushed 1 commit to campus:c11-criteria-based-filter-search-MP-pn
201611081540 PN pabodhaW pushed 1 commit to campus:c11-criteria-based-filter-search-MP-pn
201611082300 PN pabodhaW pushed 2 commits to campus:c11-criteria-based-filter-search-MP-pn
This issue is not working with the new solution mentioned in rtc 201611081130 PN. 404 issue is encountered while Ajax call firing. So the error needs to be fix. - WIP
201011091719 PN pabodhaW pushed 5 commits to campus:c11-criteria-based-filter-search-MP-pn
201611101413 PN pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-MP-pn
201611101629 PN pabodhaW pushed 2 commits to campus:c11-criteria-based-filter-search-MP-pn
201611101630 PN
Comments for QA
Uncaught Error: DataTables warning: table id=example - Cannot reinitialise DataTable. For more information about this error, please see http://datatables.net/tn/3(…) http://www.campus.dev:8080/dist/bower-components/fonts/glyphicons-halflings-regular.woff2 Failed to load resource: the server responded with a status of 404 (Not Found) http://www.campus.dev:8080/dist/bower-components/fonts/glyphicons-halflings-regular.woff Failed to load resource: the server responded with a status of 404 (Not Found) http://www.campus.dev:8080/dist/bower-components/fonts/glyphicons-halflings-regular.ttf Failed to load resource: the server responded with a status of 404 (Not Found)
@tharinduw This if FYI. Moving this issue to @HimashaFernando.
201611141014 PN pabodhaW pushed 1 commit to campus:c11-criteria-based-filter-search-MP-pn
201611141014 PN Moved c11-criteria-based-filter-search into crev stage.
201611161500 AS Code review comments Improvements
@pabodhaW FYA
201611161637 PN pabodhaW pushed 3 commits to campus:c11-criteria-based-filter-search-MP-pn
201611162119 PN Testing Guide.
What has been done(Scope) This issue defines the main filter search for courses. User can select any given criteria and select courses accordingly. Currently back-end code has done using pure SQL. But in future this needs to implement using a proper search methodology such as Elastic Search, Soler or Luscene.
Changed Files $ git diff --name-status d776aa1a90c40f68aab0b87f6c3d3a20339d12f3..5b1986c8525b556f796028f949e5a15662555978
Grade of risk of change High
Sprint released Sprint 1
Unit Test Done
How can it be tested Browse : localhost:8080 > All Courses > Select criteria as user wish > Click 'Apply Search'
What will it affect To the user's course selection.
What user roles are affected public user/admin/course provider
Other comments
DataTables warning: table id=example - Cannot reinitialise DataTable. For more information about this error, please see http://datatables.net/tn/3(…) http://www.campus.dev:8080/dist/bower-components/fonts/glyphicons-halflings-regular.woff2 Failed to load resource: the server responded with a status of 404 (Not Found) http://www.campus.dev:8080/dist/bower-components/fonts/glyphicons-halflings-regular.woff Failed to load resource: the server responded with a status of 404 (Not Found) http://www.campus.dev:8080/dist/bower-components/fonts/glyphicons-halflings-regular.ttf Failed to load resource: the server responded with a status of 404 (Not Found)
201611162125 PN Code modifications after crev.
rtc 201611161500 AS
1 Remove unused imports. PublicCmdFactory.java
Completed
2 It's better to implement reset button in the UI for reset fields and labels, after search. I think it's user friendly.
Completed To achieve this I used the checkbox near 'All'. Once user click on it the elements will be reset.
Editable search functionality supplied to the UI by using data-list, which is comes with HTML5. Once user typed something on data-list and reset it using a jQuery/JavaScript event, could not complete within the code. Which means that if user select "All - checkbox", all the UI elements will refresh other than editable search fields. (i.e Category, Institute and District). This is to be resolved after completing the UI enhancements. KTD with @tharakaGen
@anuradhars assigning this back to you to do the verification.
201611171250 AS Code review comments rtc 201611162125 PN
To achieve this I used the checkbox near 'All'. Once user click on it the elements will be reset.
c11: added a name and id to checkbox near 'All'. - 5b1986c c11: adding reset functionality via check-box -WIP. - b493c69 c11: removed unwanted alerts from ui-populate-helper.js script. / by pabodhaW 8778788 Editable search functionality supplied to the UI by using data-list, which is comes with HTML5. Once user >typed something on data-list and reset it using a jQuery/JavaScript event, could not complete within the >code. Which means that if user select "All - checkbox", all the UI elements will refresh other than editable >search fields. (i.e Category, Institute and District). This is to be resolved after completing the UI >enhancements. KTD with @tharakaGen
- fixed
pushed 2 commits to campus:c11-criteria-based-filter-search-MP-pn
Crev pass, move to RFQA.
201611231330 CN
QA comments
1.Load the site and go to the All courses page(Assumed that All-5) >>And select - All and click on APPLY SEARCH >>Then it is going to filter all search result >>After that go to the Search text box and search invalid record >>Then it is going to display the message "No data available in table">> And check the count of All /Major>>It is still displayed as All-5 and Major-6 :: It should be updated count as 0 for ALL/Major category when there is no data available in the table.
2.Noticed following errors on view course page.
3.Noticed following errors when search/select All and major
4.Drop downs(Select Educational area,Select Institute and Select District) list is viewed as empty list in IE and Firefox browses.
5.Its better to remove the ids of Drop downs(Select Educational area,Select Institute and Select District)
6.Sorting function is not working in Institute column.
Assigned back to @pabodhaW to consider above points.
201611241120 PN MX Fixes are done
pabodhaW pushed 4 commits to campus:c11-criteria-based-filter-search-MP-pn
MX Fixes rtc 201611231330 CN QA comments
fixed by changing ui-populate-helper.js file to change the course count on DataTable search and sort events.
fixed by adding higher version of bootstrap.min.js file and google fonts folder to the war file.
fixed by selecting the display images from C:\sdb\ctxdeploy\education.war\provider\logo(providecode) folder. Please add this folder to the given path if you don't have any image yet. provider.zip
This issue is browser dependent and will talk with @tharakaGen. This issue noted while dev stage and couldn't do a fix yet.
This issue is also known issue. Will be resolved on styling stage.
Sorting function is coming from the default bootstrap settings. And sorting is not working because column is only a image.
Moving this to crev stage and assigning @anuradhars. @tharinduw FYI.
201611251135 AS Code review comments rtc 201611241120 PN QA comments are fixed
Moving this to QA stage and assigning @Chamindana
201611281715 CN -Local test cycle 2 summary
rtc 201611241120
Error 1, 2, 3, from test cycle 1 All fixed. Tested and verified.
@pabodhaW told me that Errors 4 & 5 will be fixed in future sprints. FYA @tharinduw
Moving the issue to next stage 'To be merged' and assigning to developer.
Business benefit: Display all the available courses in a variable manner according to one or more filters. For the public user we can not directly say what are the institutes that should display first. Therefore it's important to find a proper way of display the all courses randomly.
Estimation: UI - 32sp Dev - 48sp Testing - 48sp