search

GENI-NSF / geni-ch

GENI clearinghouse services
Other
3 stars 6 forks source link

Bug in generating new usernames #618

Open hussamnasir opened 4 years ago

hussamnasir commented 4 years ago

https://github.com/GENI-NSF/geni-ch/blob/b6626a14e95768ba33bbc1faca9e4e74b0040920/plugins/marm/MAv1Implementation.py#L105 In cases where email address do not have any alphabets in then to use in the genration of a geni username, this variable statically assigned "geni1" as a prefix. Later down in the code line 114, the for loop counts to a max of 99 and also imposing a restriction that the len(username) is within 6 characters. Well we hit the limit of "geni199" today after which new users were not being created and GENI Portal/CH responding with errors. We need a better way of generating the username in such cases. For now my patch just replaces "geni1" assignment to "geni2" which is good for another 99 more such cases. Quick and dirty. This has been patched on the production server and a code patch here will follow soon.

ahelsing commented 4 years ago

My apologies - that sounds like my code.

My memory is that because the username is combined with the CH name et al, that full protogeni slice name length limits were a problem, but I could be wrong. (Was it slice name? Something else?) What are the normal GENI username length limits? Also 6? Could we replace that 1 or 2, as well as the following 2 characters with and give ourselves 36^3 usernames?