search

GENI-NSF / geni-portal

A UI for a GENI clearinghouse
Other
3 stars 8 forks source link

Array to string conversion in am_client.php at line 811, 845, and 884 #1793

Open tcmitchell opened 7 years ago

tcmitchell commented 7 years ago

In several places in am_client.php the array of AM URLs is included in a string which causes a warning in the portal log: Array to string conversion in /usr/share/geni-ch/lib/php/am_client.php on line 811.

We could instead use print_r($am_urls, TRUE) to explicitly create a string and avoid the warning message.

tcmitchell commented 7 years ago

Using print_r results in a lengthy log message that includes the AM URL(s), special characters (representing newlines), and all the extra Array stuff PHP wants to display. It avoids the warning message, but clutters up the syslog significantly. Is there benefit to listing the AM URL(s)? Or is user and slice info enough?