GENIE-MC / Generator

The popular GENIE Generator product is used by nearly all accelerator neutrino experiments and it plays a key role in the exploitation of neutrino data. The Generator implements a modern software framework and it includes state-of-the-art physics modules. It captures the latest results of the GENIE global analysis of neutrino scattering data and includes several tunes that were produced using the proprietary Comparisons and Tuning products. The GENIE physics model is universal and comprehensive: It handles all neutrinos and targets, and all processes relevant from MeV to PeV energy scales. The Generator includes several tools (flux drivers, detector geometry navigators, specialized event generation apps, event reweighting engines) to simulate complex experimental setups in full detail and to support generator-related analysis tasks.
http://www.genie-mc.org
48 stars 93 forks source link

Implement time shift in GSimpleNtpFlux::MoveToZ0() #387

Closed sjgardiner closed 9 months ago

sjgardiner commented 9 months ago

The GSimpleNtpFlux class allows the user to shift the starting z coordinate for a neutrino ray off of the flux window. When this is done, the other spatial coordinates are updated accordingly, but the time is set to zero.

The failure to set a consistent shift to the starting time appears to be the cause of a problem recently encountered when generating dirt samples in SBND (https://github.com/SBNSoftware/sbndcode/issues/410). This pull request implements the missing time shift to resolve the problem.

sjgardiner commented 9 months ago

Lan Nguyen did some high-stats tests of the fix on the FNAL grid, and everything looks good now for SBND. Thanks for having a look, @nusense, I'll go ahead an merge this.