search

GENIE-MC / Generator

The popular GENIE Generator product is used by nearly all accelerator neutrino experiments and it plays a key role in the exploitation of neutrino data. The Generator implements a modern software framework and it includes state-of-the-art physics modules. It captures the latest results of the GENIE global analysis of neutrino scattering data and includes several tunes that were produced using the proprietary Comparisons and Tuning products. The GENIE physics model is universal and comprehensive: It handles all neutrinos and targets, and all processes relevant from MeV to PeV energy scales. The Generator includes several tools (flux drivers, detector geometry navigators, specialized event generation apps, event reweighting engines) to simulate complex experimental setups in full detail and to support generator-related analysis tasks.
http://www.genie-mc.org
43 stars 94 forks source link

Fix kinematic phase space issue in HybridXSecAlgorithm (due to RosenbluthPXSec) #396

Closed idkakorin closed 6 months ago

idkakorin commented 6 months ago

Ad hoc solution of problem with inappropriate kinematic phase space reported by @jtenavidal, so she can continue working.

The reason of problem: it is intended for LlewelynSmith, but also used by Rosenbluth.

A more thoughtful solution could be:

  1. Specify in the configuration file the phase space appropriate for each algorithm.
  2. Implement in RosenbluthPXSec the analog of method LwlynSmithQELCCPXSec::FullDifferentialXSec.
jtenavidal commented 6 months ago

After this fix I can get all my events as expected

idkakorin commented 6 months ago

After short conversation with @afropapp13 in Slack: return to correct Jacobian for RosenbluthPXSec.

afropapp13 commented 6 months ago

Located documentation from back at the time https://genie-docdb.pp.rl.ac.uk/DocDB/0002/000214/002/rosenbluth_fix_for_v3.2.pdf

The current version is the correct one so i propose that we close the PR

idkakorin commented 6 months ago

Thanks for explanation @afropapp13. However, your suggestion to close PR is premature as it is mainly addressed to fix this issue #397.