This pull request should probably supersede #4, although we may want to revisit removing the hard exit when Reweight encounters significant unitarity violation.
Fix erroneous call to genie::utils::rew::FateFraction() in genie::utils::rew::WhichFateFractionScaleFactor(). The former was updated
for Reweight v1.0.0 to avoid relying on a hard-coded nuclear mass number
(see commit 7b544ab6a1). Usage of FateFraction() in
WhichFateFractionScaleFactor() had not yet been adjusted to take this
change into account. The failure to do so led to incorrect lookups of the
untweaked fate fraction. A scaling factor of 1.0 (corresponding to the
untweaked value) was mistakenly interpreted as a mass number (and
implicitly converted to int), leading to lookups for A = 1 instead of the
correct target nucleus. The impact of this bug on users was occasional
severe unitarity violation when reweighting hadron fate fractions.
This pull request should probably supersede #4, although we may want to revisit removing the hard exit when Reweight encounters significant unitarity violation.
Fix erroneous call to genie::utils::rew::FateFraction() in genie::utils::rew::WhichFateFractionScaleFactor(). The former was updated for Reweight v1.0.0 to avoid relying on a hard-coded nuclear mass number (see commit 7b544ab6a1). Usage of FateFraction() in WhichFateFractionScaleFactor() had not yet been adjusted to take this change into account. The failure to do so led to incorrect lookups of the untweaked fate fraction. A scaling factor of 1.0 (corresponding to the untweaked value) was mistakenly interpreted as a mass number (and implicitly converted to int), leading to lookups for A = 1 instead of the correct target nucleus. The impact of this bug on users was occasional severe unitarity violation when reweighting hadron fate fractions.