GENIVI / AudioManager

The GENIVI Audiomanager
https://genivi.github.io/AudioManager
Other
25 stars 17 forks source link

Signal term is not handled immediately #12

Closed svenorth closed 6 years ago

svenorth commented 7 years ago

Behavior: Sent signal term to GAM but process did not terminate. After sending a dbus message the signal was handled correctly.

Expected behavior: GAM terminates immediately.

GAM setup: cmake -DWITH_DOCUMENTATION=OFF -DWITH_TESTS=OFF -DWITH_DLT=OFF -DWITH_TELNET=OFF -DWITH_DBUS_WRAPPER=ON -DWITH_CAPI_WRAPPER=OFF -DWITH_SYSTEMD_WATCHDOG=OFF -DCMAKE_BUILD_TYPE=Debug ..

Plugin setup: cmake -DWITH_DOCUMENTATION=ON -DWITH_COMMAND_INTERFACE_DBUS=ON -DWITH_GENERIC_CONTROLLER=ON -DCMAKE_BUILD_TYPE=Debug ..

Proposal: Use non blocking read operation in GAM main loop.

GeniviAMmaintainer commented 7 years ago

most likely due to generic controller, please check with the controller what is happening here.

svenorth commented 7 years ago

Are you sure? The Audio Manager uses ppoll thus the signals SIGINT, SIGTERM, ... are blocked.

GeniviAMmaintainer commented 7 years ago

with the new pull request, we have implemented sigfd. please recheck if this fixed the bug

GeniviAMmaintainer commented 7 years ago

https://github.com/GENIVI/AudioManager/pull/16

JensLorenz commented 6 years ago

PR#16 merged since a long time. The bug can be closed.