search

GENIVI / AudioManager

The GENIVI Audiomanager
https://genivi.github.io/AudioManager
Other
25 stars 19 forks source link

Utility updates capi fixes #26

Closed GeniviAMmaintainer closed 6 years ago

GeniviAMmaintainer commented 6 years ago

Remaining fixes from utility updates. Will close other pull request

JensLorenz commented 6 years ago

Review is pass. Just the spaces issues are remaining which will be addressed with our next PR. I will run on our side tests with the patch set and acknowledge once they are passing.

JensLorenz commented 6 years ago

We actually face issues with the PR. Please revert from master. Other than that I have question already raised before going ahead with the others: Why was the runtime thread_id check introduced? This cause the most issues on our side.

@GeniviAMmaintainer: The question still persists. Please give some information why the runtime thread_id check was introduced? I would like to issue an reworked PR of yours and therefore I would like to know if this change is needed or not! Thx