GENIVI / AudioManager

The GENIVI Audiomanager
https://genivi.github.io/AudioManager
Other
25 stars 19 forks source link

Issue #24 clean up whitespace #35

Closed JensLorenz closed 6 years ago

JensLorenz commented 6 years ago

This PR addresses the white space issues and applies new formatting according to the Foo/uncrustify.cfg. In case there are different understandings about style we should discuss about it.

This PR will be an iterative one and might imply to update the uncrustify.cfg according to findings.

gunnarx commented 6 years ago

Overall it looks good to me. I did some checking of the differences after removing all whitespace and did not spot anything changed that should not change. In addition to changing whitespace, the commit removes some unnecessary semicolons at the end of method definitions, like this:

f() {
};

changed to

f() {
}

It also seems to change some expressions like:

some_expression();

to

some_expression()
{ }

which is probably also correct in those cases.

I didn't find any really odd formatting except for the commas noted above.