search

GENIVI / AudioManager

The GENIVI Audiomanager
https://genivi.github.io/AudioManager
Other
25 stars 19 forks source link

Genivi imp #39

Closed GeniviAMmaintainer closed 6 years ago

GeniviAMmaintainer commented 6 years ago

follow up to PR#36 closed by mistake

GeniviAMmaintainer commented 6 years ago

merged and closed the last PR#36 by mistake. Reverted master branch and created new PR for following up. Database macros cannot be used as suggested, other changes were applied.

JensLorenz commented 6 years ago

Looks good to me. Would recommend to squash the patches together and rebase the PR in order to keep two patch files only. But it is not necessary...

JensLorenz commented 6 years ago

Actually now you rebased and squashed everything together in one single patch. I was requesting you to have only the CAmDatabaseHandler modifications to merged into one patch. DLT should still seperate. Cleanup for the serializer too.

Sorry for any misunderstanding

GeniviAMmaintainer commented 6 years ago

Anyway, I think it is still ok to keep the squashed commit - there are not so many files changed.