search

GENIVI / AudioManager

The GENIVI Audiomanager
https://genivi.github.io/AudioManager
Other
25 stars 19 forks source link

typo correction on CAmSerializer.h #51

Closed daduki closed 4 years ago

daduki commented 4 years ago

CAmDelegagePtr > CAmDelegatePtr mListDelegatePoiters > mListDelegatePointers getListDelegatePoiters > getListDelegatePointers

ghost commented 4 years ago

Hello daduki, thank you for contributing. Regarding CAmDelegagePtr and mListDelegatePoiters, they are declared private and can be corrected without any impact on existing applications. Regarding function getListDelegatePoiters(), it is part of the public interface and might be used by example plugins, customer-designed plugins and also customer client applications. So correcting this small typo should be done with great care. I propose establishing a new function with the correct spelling beside the existing, redirect the existing and make a note to it which marks it as deprecated.

We can discuss this in the associated mailing list. Please subscribe to https://lists.genivi.org/mailman/listinfo/genivi-audio-manager_lists.genivi.org.

daduki commented 4 years ago

As you suggested, getListDelegatePointersSize would be good for renaming. Also inline redirection is added (getListDelegagePoiters to getListDelegatePointersSize) on #53

Update CAmSerializer.h(typo correction regarding getListDelegagePoiters) #53

daduki commented 4 years ago

In #53 all the changes are included If #53 is merged, please ignore this commit(#51) Thanks

daduki commented 4 years ago

Using #53 instead of #51 So, I closed this.