search

GENIVI / AudioManager

The GENIVI Audiomanager
https://genivi.github.io/AudioManager
Other
25 stars 17 forks source link

compiler flags in audiomanager.pc.in #60

Open kodiakz opened 2 years ago

kodiakz commented 2 years ago

audiomanager.pc.in sets Cflags to include _AUDIOMANAGER_CMAKE_CXXFLAGS, which in turn brings in the -pedantic flag. This is intrusive to the user of that pkg-config, enforcing to provide own code to be compatible - and sometimes impossible if using incompatible 3rd party code. What is the intention of including extraneous flags here? -pedantic should not be enforced in the interface.

ghost commented 2 years ago

This is most likely a relict from the early days of the audiomanager. Although the AM itself claims conformity with ISO C++, it seems reasonable not strictly requiring this from users of the accompanying libraries. So I propose removing this flag from the projects exports (both pkgconfig and cmake).