Bumping cpp-peglib to v1.3.7

GENIVI / CANdb

Library for parsing CAN bus database description formats

Mozilla Public License 2.0

145 stars 46 forks source link

Bumping cpp-peglib to v1.3.7 #40

Closed btaczala closed 3 years ago

btaczala commented 3 years ago

Maybe fixes #39

enricop commented 3 years ago

Hello,

yesterday I've tried that last master commit of peglib and the parsing time on x86_64 went from

CAN1.dbc loaded in = 981[ms]
CAN2.dbc loaded in = 2066[ms]

CAN1.dbc loaded in = 692[ms]
CAN2.dbc loaded in = 1512[ms]

so it's good to migrate to peglib c++17 like you did.

However that last master commit has the same problem on ARM systems.

One small note: in the dbc_parser.cpp code you can use also the method: token_to_string() of struct SemanticValues

btaczala commented 3 years ago

@enricop OK so switching to peglib does not solve the performance issues on ARM? Can you specify which ARM system you're using (specifically which ARM core: A family, R family M family)? Are you running this under Linux or on bare metal?

enricop commented 3 years ago

Hello,

thanks for bumping the submodule. Yes, the issue for ARM systems is in peglib master branch.

Peglib developers are now investigating for a solution in the library: https://github.com/yhirose/cpp-peglib/issues/173

We are using both ARM A15 and ARM A9 under Linux.

I'll close CANdb issue when they commit a possible solution on peglib repository, so you can bump again the submodule.