Closed byunghyuk closed 2 years ago
Merging #237 (48ee275) into master (c1cfda9) will decrease coverage by
1.75%
. The diff coverage is11.29%
.
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 98.83% 97.07% -1.76%
==========================================
Files 96 98 +2
Lines 3009 3081 +72
==========================================
+ Hits 2974 2991 +17
- Misses 35 90 +55
Impacted Files | Coverage Δ | |
---|---|---|
src/components/cansignalsender/cansignalsender_p.h | 100.00% <ø> (ø) |
|
src/components/cansignaldata/searchmodel.cpp | 37.93% <5.26%> (-62.07%) |
:arrow_down: |
...c/components/cansignalsender/cansignalsender_p.cpp | 78.37% <5.88%> (-21.63%) |
:arrow_down: |
...ents/cansignalsender/cansignalsendertablemodel.cpp | 8.69% <8.69%> (ø) |
|
src/components/cansignaldata/cansignaldata_p.cpp | 100.00% <100.00%> (ø) |
|
...onents/cansignalsender/cansignalsendertablemodel.h | 100.00% <100.00%> (ø) |
|
src/gui/projectconfig/projectconfig.cpp | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c1cfda9...48ee275. Read the comment docs.
@byunghyuk Thanks for the new feature. New functionality is not covered by unit tests, but I don't want to block it any longer. If you will find a time to add relevant unit tests as a separate PR I would appreciate it :-)