Blade directive markup - Githubissues

GENL / matice

Use your Laravel translations in JavaScript.

MIT License

98 stars 14 forks source link

Blade directive markup #7

Closed IamXytric closed 3 years ago

IamXytric commented 3 years ago

Expected behavior

<!-- Matice Laravel Translations generated -->
<script>
  const Matice = {
    locale: "en",
    fallbackLocale: "en",
    translations: { ... }
  }
</script>

Current behavior

<!-- Matice Laravel Translations generated -->
<div id="matice-translations">
  <script type="text/javascript">
    const Matice = {
      locale: "en",
      fallbackLocale: "en",
      translations: { ... }
    }
  </script>
</div>

Reasoning

The div#matice-translations seems excessive and <div>s are not supported within the <head> forcing the directive into the <body>. Not that this is a big problem, but having the option to put it in <head> would be nice.
This is just a very minor nuisance, but in HTML5 it is recommended to omit [type="text/javascript"] from <script>. Ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script

Versions

Laravel: 8.15.0
Matice: 1.1.2

GENL commented 3 years ago

Hi! Now possible with the release 1.1.3 . Moved the id in the script tag directly.