search

GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.
MIT License
87 stars 25 forks source link

Circle changes #1233

Closed simon-leech closed 1 month ago

simon-leech commented 2 months ago

Opening this up as a draft as its not ready yet.

Changes Included:

If you provide a circle.radius and circle.units then the panel is not provided, and instead you just have the button to begin drawing. "circle": { "label": "1km Catchment", "radius": 1000, "units": "meter" }

simon-leech commented 1 month ago

@dbauszus-glx I have removed the geojson import from this PR - just got the circle changes now :)

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

dbauszus-glx commented 1 month ago

I added the hidePanel flag in order to maintain the current default behaviour. A radius and unit will always be assigned as default. The config object will just override the defaults. The dictionary label can be assigned in the defaults since the config will override. A spread operator should be used for this rather than object assignment.