search

GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.
MIT License
87 stars 25 forks source link

Filter Fix #1236

Closed simon-leech closed 2 months ago

simon-leech commented 2 months ago

In the filter.mjs - we were calling the generateMinMax function to get the data for the minimum or maximum values of the filter sliders. However, we were not awaiting these which meant that the values were not being returned correctly, and the no data message was being shown when there was actually data.

simon-leech commented 2 months ago

Just pushed another commit to check that the filter.min and filter.max are numeric, if not the no data message is returned

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

AlexanderGeere commented 2 months ago

Added a check for whether response is null before checking response[minmax].

Added a simple test workspace as well: Filter workspace

Looks good to me though!