Key is ID = Throw Error

[simon-leech]

In the location_update and location_new queries, it is possible to update the id field on the table on the db. However, doing so will actually overwrite the %{id} reserved parameter. Example using location_update

UPDATE ${_.table} SET ${fields.join()} WHERE ${_.layer.qID} = %{id};

You are on location unique_id = 777. You want to update id field to be 123. The query you would expect to look like

UPDATE schema.table SET id = 123 WHERE unique_id = 777`

It actually does this

UPDATE  schema.table SET id = 123 WHERE unique_id = 123`

Proposed Fix

• Simply don't allow the id field to be updated.

Long-Term Fix

• We should replace %{id} with a better unique descriptor, such as %{infoj_id} or similar that wouldn't be used a field name on the db

[simon-leech]

I just pushed a commit to make sure the Error message throws the Error using the layer.qID not 'id' so it is explicit what the issue is.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud