Modal Dialog element

[RobAndrewHurst]

Pull Request Template

Description

• Replaced the <div> element in the modal creation with the dialog.
• We append the
  element to the target.
• And replaced the target element remove with close() method that is part of the
  tag

GitHub Issue

• 1124

Type of Change

Please delete options that are not relevant, and select all options that apply.

• ✅ Enhancement

How have you tested this?

Test this with any form of modal. Please check for any odd behaviours.

Testing Checklist

• ✅ Existing Tests still pass
• ✅ Ran locally on my machine

Code Quality Checklist

• ✅ My code follows the guidelines of XYZ
• ✅ My code has been commented
• ✅ Documentation has been updated
• ✅ New and existing unit tests pass locally with my changes
• ✅ Main has been merged into this PR

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[RobAndrewHurst]

Looking at this again, there are a whole array of issues that I need to handle. I am closing this and will reopen when those are handled.