simon-leech commented 3 months ago

Filter Min Fix

Description

I have added a new filter_minmax query that returns an array of both min and max values. This removed some of the complexity in the generateMinMax function as you no longer need to pass in a string of "min" or "max".

I have added a new filter.minmax array that gets set to [filter.min, filter.max] initially. The benefit of this is that by extracting the query response from the filter.min and filter.max values, we separate providing a specific min or max in the configuration vs getting them from the database.

I have resolved the issue with clear and reload of the filter, it will now update the filter values using the query. I have added a new message that displays when the min and max are identical.

GitHub Issue

#1301

Type of Change

Please delete options that are not relevant, and select all options that apply.

✅ Bug fix (non-breaking change which fixes an issue)

How have you tested this?

Ran this using a field that contained 0 as the minimum field value.

Testing Checklist

✅ Existing Tests still pass
✅ Ran locally on my machine

Code Quality Checklist

✅ My code follows the guidelines of XYZ
✅ My code has been commented
✅ Documentation has been updated
✅ New and existing unit tests pass locally with my changes
✅ Main has been merged into this PR

simon-leech commented 3 months ago

I have added a new filter_minmax query that returns an array of both min and max values. This removed some of the complexity in the generateMinMax function as you no longer need to pass in a string of "min" or "max".

I have added a new filter.minmax array that gets set to [filter.min, filter.max] initially. The benefit of this is that by extracting the query response from the filter.min and filter.max values, we separate providing a specific min or max in the configuration vs getting them from the database.

I have resolved the issue with clear and reload of the filter, it will now update the filter values using the query. I have added a new message that displays when the min and max are identical.