search

GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.
MIT License
87 stars 25 forks source link

Ensure that the style.zIndex is only used in the olStyle module #1326

Closed dbauszus-glx closed 3 months ago

dbauszus-glx commented 3 months ago

The style.zIndex must not be confused with the layer.zIndex.

The style.zIndex defines the render order within a layer.canvas

The layer.index defines the order of layer canvases within the Openlayers mapview.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
35.3% Duplication on New Code

See analysis details on SonarCloud

RobAndrewHurst commented 3 months ago

@simon-leech We will need to add in a condition to the auto-update to move the zIndex from the layer.style.zIndex to the layer.zIndex

simon-leech commented 3 months ago

@RobAndrewHurst Good point! PR for that fix is here https://github.com/GEOLYTIX/xyz-ignite/pull/56