GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.
MIT License
86 stars 25 forks source link

Style Parser : Change the default key message to detail which keys need changing #1329

Closed KieronFerrey closed 1 week ago

KieronFerrey commented 2 weeks ago

Pull Request Template

Description

Included the object keys that violated the test in the warning message to easily understand what needs changing.

Type of Change

Please delete options that are not relevant, and select all options that apply.

How have you tested this?

Tested using a style that violated the test, tested against a default style with no keys, one and two all of which behaved correctly.

Testing Checklist

Please delete options that are not relevant, and select all options that apply.

Code Quality Checklist

Please delete options that are not relevant, and select all options that apply.

simon-leech commented 1 week ago

I actually think we should update the styleparser tests with this change too, while we are here!

RobAndrewHurst commented 1 week ago

Putting into draft until tests are updated

RobAndrewHurst commented 1 week ago

@simon-leech @KieronFerrey

I have fixed the two hover and label tests to better suite the actual logic of the module. There is still an issue where the bogus key is not being removed from the style object. Let me know if you have any ideas.

simon-leech commented 1 week ago

Closed as this PR has the same change in - #1331