GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.

MIT License

86 stars 25 forks source link

maplibre and style.zIndex #1338

Closed simon-leech closed 1 week ago

simon-leech commented 1 week ago

Pull Request Template

Description

Added a warning on layer.style.zIndex deprecation and to use layer.zIndex instead in styleParser.
In PR https://github.com/GEOLYTIX/xyz/pull/1326 the maplibre layer.zIndex was uncommented. This was a mistake as it doesn't work correctly. I re-commented but added information about why it is commented out.

Type of Change

Please delete options that are not relevant, and select all options that apply.

✅ Bug fix (non-breaking change which fixes an issue)

How have you tested this?

Tested locally.

Testing Checklist

Please delete options that are not relevant, and select all options that apply.

✅ Existing Tests still pass
✅ Updated Existing Tests
✅ New Tests Added
✅ Ran locally on my machine

Code Quality Checklist

Please delete options that are not relevant, and select all options that apply.

✅ My code follows the guidelines of XYZ
✅ My code has been commented
✅ Documentation has been updated
✅ New and existing unit tests pass locally with my changes
✅ Main has been merged into this PR

simon-leech commented 1 week ago

Moving back into the draft - the issue isn't with the zIndex assignment its when you turn on the layers that they appear in the wrong order.

simon-leech commented 1 week ago

I can't review as it was my PR but all working for me correctly now :)