search

GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.
MIT License
88 stars 26 forks source link

deprecate mbtiles format #1617

Closed dbauszus-glx closed 1 month ago

dbauszus-glx commented 1 month ago

The mbtiles format dependent on a legacy version of the maplibre library has now been removed.

dbauszus-glx commented 1 month ago

Can StyleParser check for this layer format and warn (can it parse to the correct format)? If you have an mbtiles layer on this PR, it just crashes without any helpful debugging or anything.

Not possible since the styleParser checks on vector styles only and mbtiles do not have a style object.

dbauszus-glx commented 1 month ago

@simon-leech You can add a deprecation warning in lib/layer/format/_format.mjs

/**
@function mbtiles
@deprecated

@description
The mbtiles layer format method has been deprecated.
*/
function mbtiles() {

  console.warn(`The mbtiles layer format method has been deprecated.`)
}
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud