Closed simon-leech closed 3 weeks ago
The dictionary keys required in a module should be added to the module documentation.
The dictionary modules should match language codes. esp and cn_trad are not language codes. not sure about cn but i think chinese is zh.
Good points - will address both of these before marking as ready for review! 👍
I forgot to commit this earlier. https://github.com/GEOLYTIX/xyz/pull/1630/commits/46bee2bc4d252309e217b663b2c2a5b4f0433d0a
I have updated the base dictionaries test to check if any additional language has a key that the english dictionaries does not then it will fail!
@dbauszus-glx Resolved - please review again
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Description
All translations are now provided in their own language file, rather than being merged in within various modules. Every language now has a translation for every English key - please note some of these were translated using AI so they will likely require manual checking.
The tests have been updated to check the merge process is working using a
test_merge
key, and to also ensure that each language has a matching translation for every English key - as English is our base language.GitHub Issue
1449
Testing Checklist
Please delete options that are not relevant, and select all options that apply.
Code Quality Checklist
Please delete options that are not relevant, and select all options that apply.