Remove data-id assignment for layer-view element

GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.

MIT License

88 stars 26 forks source link

Closed dbauszus-glx closed 3 weeks ago

dbauszus-glx commented 3 weeks ago

A data-id is not a class!

A data-id is a pseudo id as the nomination suggests.

The data-id for a layer view/drawer element should be the layer.key.

The data-id for a [layer] group view/drawer should be the group id.

There should not be a queryselector for data-id=layer-drawer which is better solved with a combo class eg. .layer-view.drawer

sonarcloud[bot] commented 3 weeks ago