GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.
MIT License
88 stars 26 forks source link

Fix Ol Version Check #1674

Closed simon-leech closed 3 weeks ago

simon-leech commented 3 weeks ago

Fix Version Check

Description

Both the OpenLayers version defined in a custom view and the current OpenLayers version of MAPP needs to be parsed to float - otherwise the check is comparing a number to a string and it will never warn on an outdated version.

GitHub Issue

1673

Type of Change

Please delete options that are not relevant, and select all options that apply.

How have you tested this?

Please describe how to test this change and how you verified it worked.

Testing Checklist

Please delete options that are not relevant, and select all options that apply.

Code Quality Checklist

Please delete options that are not relevant, and select all options that apply.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud