search

GEOLYTIX / xyz

An open source javascript framework for spatial data and application interfaces.
MIT License
88 stars 26 forks source link

Warn on entry.layer not in locale #1691

Closed dbauszus-glx closed 2 weeks ago

dbauszus-glx commented 2 weeks ago

The layer entry as a replacement for the mvt_clone will have an entry.layer property used to lookup a layer in the mapview.locale.

The [layer] entry method must return and should warn if the entry.layer property is defined but the layer is not found in the mapview.locale.

I also noticed that the [entry] layer.tables zoom restriction is not respected on first execution of the method but only once the changeEnd event is executed. This has been fixed in this patch PR as well.

dbauszus-glx commented 2 weeks ago

I notice another bug testing this with a featureSet clone. A [layer] entry may have a featureSet or featureLookup object but not both. Otherwise the featureSet will be ignored.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud